Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added rosdep key for ignition-edifice, make it a mandatory dependency #31

Merged
merged 2 commits into from
Aug 18, 2021
Merged

Added rosdep key for ignition-edifice, make it a mandatory dependency #31

merged 2 commits into from
Aug 18, 2021

Conversation

luca-della-vedova
Copy link
Member

New feature implementation

Implemented feature

Make Ignition Edifice a mandatory dependency of rmf_building_sim_ignition_plugins by adding it to the package.xml / and removing the hack that silently didn't compile it if ignition-edifice wasn't installed.

Implementation description

A few months ago ignition-edifice was added as a rosdep key hence we can install it through rosdep. This will fix the release package for the plugins to actually have the plugins (it was empty before) and make the demos work on binary installations, as well as removing the need for users to install ignition manually if they want to use it to run demos.

@luca-della-vedova
Added rosdep key for ignition-edifice, made it a mandatory dependency
c7e7496 
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
@codecov
Copy link

codecov bot commented Jul 14, 2021 •
edited
Loading

Codecov Report

Merging #31 (a365806) into main (a80cb6e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main     #31     +/-   ##
=======================================
  Coverage   0.00%   0.00%             
=======================================
  Files         94     138     +44     
  Lines       8066   12873   +4807     
=======================================
- Misses      8066   12873   +4807
Flag Coverage Δ
tests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lation/rmf_robot_sim_common/src/slotcar_common.cpp
...ation/rmf_robot_sim_common/src/readonly_common.cpp
...f_simulation/rmf_building_sim_common/src/utils.cpp
...tion/rmf_robot_sim_common/src/dispenser_common.cpp
...ation/rmf_building_sim_gazebo_plugins/src/lift.cpp
...uilding_sim_gazebo_plugins/src/crowd_simulator.hpp
...lation/rmf_building_sim_common/src/door_common.cpp
...ation/rmf_building_sim_gazebo_plugins/src/lift.cpp
...tion/rmf_robot_sim_common/src/dispenser_common.cpp
..._sim_common/include/rmf_robot_sim_common/utils.hpp
... and 218 more

@luca-della-vedova luca-della-vedova merged commit 7e981e4 into main Aug 18, 2021
@luca-della-vedova luca-della-vedova deleted the feature/ignition_rosdep_key branch August 18, 2021 08:54
@luca-della-vedova luca-della-vedova mentioned this pull request Sep 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoag marcoag marcoag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luca-della-vedova @marcoag